Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrate a Kernel Manager when calling GatewayKernelManager.start_kernel with a kernel_id #788

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Apr 12, 2022

Fixes #786

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #788 (39df852) into main (cc8bdf4) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   70.32%   70.31%   -0.01%     
==========================================
  Files          62       62              
  Lines        7554     7555       +1     
  Branches     1248     1248              
==========================================
  Hits         5312     5312              
- Misses       1859     1860       +1     
  Partials      383      383              
Impacted Files Coverage Δ
jupyter_server/gateway/managers.py 59.66% <66.66%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8bdf4...39df852. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @Zsailer.

@kevin-bates kevin-bates merged commit 64555ff into jupyter-server:main Apr 12, 2022
@Zsailer Zsailer deleted the kernel-id-flow-in-gateway branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How should a Gateway's start_kernel behave when a kernel_id is given?
3 participants